Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1683553003: Add missing Dart_ExitScope calls in some of the VM unit tests. (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing Dart_ExitScope calls in some of the VM unit tests. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/14417a785115e2f13de10b77921d0b8dba510736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/custom_isolate_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
siva
4 years, 10 months ago (2016-02-09 20:55:22 UTC) #3
srdjan
lgtm
4 years, 10 months ago (2016-02-09 20:57:05 UTC) #4
siva
4 years, 10 months ago (2016-02-09 21:40:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14417a785115e2f13de10b77921d0b8dba510736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698