Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: runtime/vm/snapshot_test.cc

Issue 1683553003: Add missing Dart_ExitScope calls in some of the VM unit tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot_test.cc
diff --git a/runtime/vm/snapshot_test.cc b/runtime/vm/snapshot_test.cc
index 210e43f306af3d573fe828a5989e018a52c4f182..35d372881c4a8badcb006fabd439bdbecc575637 100644
--- a/runtime/vm/snapshot_test.cc
+++ b/runtime/vm/snapshot_test.cc
@@ -1537,6 +1537,7 @@ UNIT_TEST_CASE(ScriptSnapshot1) {
EXPECT(script_snapshot != NULL);
result = Dart_LoadScriptFromSnapshot(script_snapshot, size);
EXPECT_VALID(result);
+ Dart_ExitScope();
}
FLAG_load_deferred_eagerly = saved_load_deferred_eagerly_mode;
@@ -1657,6 +1658,7 @@ UNIT_TEST_CASE(ScriptSnapshot2) {
// Invoke the test_b function.
result = Dart_Invoke(lib, NewString("test_b"), 0, NULL);
EXPECT(Dart_IsError(result) == saved_enable_type_checks_mode);
+ Dart_ExitScope();
}
Dart_ShutdownIsolate();
free(full_snapshot);
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698