Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1683503002: [Media Router] Simplify WebUI element positioning functions. (Closed)

Created:
4 years, 10 months ago by apacible
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

[Media Router] Simplify WebUI element positioning functions. Removed shownComponentsChanged_() in favor of updateElementPositioning_(). Moved async() method to ensure any microtasks such as first run flow or issue stamping has concluded before the positioning of the WebUI elements is determined. BUG=583203 Review URL: https://codereview.chromium.org/1652203004 Cr-Commit-Position: refs/heads/master@{#373116} (cherry picked from commit 75b93c431dd27c7069969e2d300312284ee886a1) Committed: https://chromium.googlesource.com/chromium/src/+/c09143df20415e8730ce516fe060f37db48f7a8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -50 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 6 chunks +33 lines, -50 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
apacible
4 years, 10 months ago (2016-02-09 01:04:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c09143df20415e8730ce516fe060f37db48f7a8d.

Powered by Google App Engine
This is Rietveld 408576698