Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1652203004: [Media Router] Simplify WebUI element positioning functions. (Closed)

Created:
4 years, 10 months ago by apacible
Modified:
4 years, 10 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Simplify WebUI element positioning functions. Removed shownComponentsChanged_() in favor of updateElementPositioning_(). Moved async() method to ensure any microtasks such as first run flow or issue stamping has concluded before the positioning of the WebUI elements is determined. BUG=583203 Committed: https://crrev.com/75b93c431dd27c7069969e2d300312284ee886a1 Cr-Commit-Position: refs/heads/master@{#373116}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -45 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 6 chunks +22 lines, -45 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
apacible
PTAL, thanks!
4 years, 10 months ago (2016-02-02 14:59:26 UTC) #7
imcheng
lgtm
4 years, 10 months ago (2016-02-02 20:21:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652203004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652203004/80001
4 years, 10 months ago (2016-02-03 00:23:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 10 months ago (2016-02-03 01:25:34 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 01:26:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75b93c431dd27c7069969e2d300312284ee886a1
Cr-Commit-Position: refs/heads/master@{#373116}

Powered by Google App Engine
This is Rietveld 408576698