ARM32 vector ops - scalarize icmp, fcmp and cast.

ARM32 vector ops - scalarize icmp, fcmp and cast.

This is part of a sequence of patches to quickly fill out vector
support by scalarizing the remaining operations. Later we can work to
generate better code.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cc69fa29cf14a3c4340f1ea4a32a1d24772b605d

[Eric Holk, 2016-02-10 18:31:14]

eholk@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, sehr@chromium.org,
stichnot@chromium.org

[Jim Stichnoth, 2016-02-10 19:08:12]

lgtm

https://codereview.chromium.org/1683153003/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1683153003/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1757: case  IceType_v8i1:
make format

https://codereview.chromium.org/1683153003/diff/20001/src/IceTargetLowering.h
File src/IceTargetLowering.h (right):

https://codereview.chromium.org/1683153003/diff/20001/src/IceTargetLowering.h...
src/IceTargetLowering.h:477: assert(isVectorType(Dest->getType()));
I would "assert(isVectorType(DestTy));" and move it one instruction below. 
(despite the break in the flow)

here and below

https://codereview.chromium.org/1683153003/diff/20001/src/IceTargetLowering.h...
src/IceTargetLowering.h:498: // Perform the arithmetic as a scalar operation.
You probably want change "arithmetic" to be more general now.

Here and below.

https://codereview.chromium.org/1683153003/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/cmp-vec.ll (right):

https://codereview.chromium.org/1683153003/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/cmp-vec.ll:1: ; Test that we handle icmp and fcmp on
vectors
End sentence with period.  :)

[Eric Holk, 2016-02-10 21:07:08]

Description was changed from

==========
ARM32 vector ops - scalarize icmp, fcmp and cast.

This is part of a sequence of patches to quickly fill out vector
support by scalarizing the remaining operations. Later we can work to
generate better code.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
==========

to

==========
ARM32 vector ops - scalarize icmp, fcmp and cast.

This is part of a sequence of patches to quickly fill out vector
support by scalarizing the remaining operations. Later we can work to
generate better code.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Eric Holk, 2016-02-10 21:07:09]

Committed patchset #2 (id:20001) manually as
cc69fa29cf14a3c4340f1ea4a32a1d24772b605d (presubmit successful).

[Eric Holk, 2016-02-10 21:07:20]

https://codereview.chromium.org/1683153003/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1683153003/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1757: case  IceType_v8i1:
On 2016/02/10 19:08:11, stichnot wrote:
> make format

Done.

https://codereview.chromium.org/1683153003/diff/20001/src/IceTargetLowering.h
File src/IceTargetLowering.h (right):

https://codereview.chromium.org/1683153003/diff/20001/src/IceTargetLowering.h...
src/IceTargetLowering.h:477: assert(isVectorType(Dest->getType()));
On 2016/02/10 19:08:11, stichnot wrote:
> I would "assert(isVectorType(DestTy));" and move it one instruction below. 
> (despite the break in the flow)
> 
> here and below

Done.

https://codereview.chromium.org/1683153003/diff/20001/src/IceTargetLowering.h...
src/IceTargetLowering.h:498: // Perform the arithmetic as a scalar operation.
On 2016/02/10 19:08:12, stichnot wrote:
> You probably want change "arithmetic" to be more general now.
> 
> Here and below.

Done.

https://codereview.chromium.org/1683153003/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/cmp-vec.ll (right):

https://codereview.chromium.org/1683153003/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/cmp-vec.ll:1: ; Test that we handle icmp and fcmp on
vectors
On 2016/02/10 19:08:12, stichnot wrote:
> End sentence with period.  :)

Done.