Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1683113003: A type should be a subtype of Function if its class declares a call function, (Closed)

Created:
4 years, 10 months ago by regis
Modified:
4 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

A type should be a subtype of Function if its class declares a call function, even if call is abstract (fixes #25550). Add regression test. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/21cad16fac8026bc2fbe81895780c876693c36a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M runtime/vm/object.h View 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 5 chunks +17 lines, -11 lines 0 comments Download
A + tests/language/regress_25550_test.dart View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 10 months ago (2016-02-10 18:33:51 UTC) #2
hausner
lgtm
4 years, 10 months ago (2016-02-10 18:49:26 UTC) #3
regis
4 years, 10 months ago (2016-02-10 18:54:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
21cad16fac8026bc2fbe81895780c876693c36a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698