Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: runtime/vm/object.h

Issue 1683113003: A type should be a subtype of Function if its class declares a call function, (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 34440a199b1312b292f766e0ad5059238d42666a..16a129e25b3dc3c7ca4aa5ff416bf74775df5dab 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -1186,6 +1186,7 @@ class Class : public Object {
RawFunction* ImplicitClosureFunctionFromIndex(intptr_t idx) const;
RawFunction* LookupDynamicFunction(const String& name) const;
+ RawFunction* LookupDynamicFunctionAllowAbstract(const String& name) const;
RawFunction* LookupDynamicFunctionAllowPrivate(const String& name) const;
RawFunction* LookupStaticFunction(const String& name) const;
RawFunction* LookupStaticFunctionAllowPrivate(const String& name) const;
@@ -1373,6 +1374,7 @@ class Class : public Object {
kAny = 0,
kStatic,
kInstance,
+ kInstanceAllowAbstract,
kConstructor,
kFactory,
};
@@ -2315,8 +2317,8 @@ class Function : public Object {
bool IsFactory() const {
return (kind() == RawFunction::kConstructor) && is_static();
}
- bool IsDynamicFunction() const {
- if (is_static() || is_abstract()) {
+ bool IsDynamicFunction(bool allow_abstract = false) const {
+ if (is_static() || (!allow_abstract && is_abstract())) {
return false;
}
switch (kind()) {
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698