Issue 16831020: windows test fix for 15221

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16831020: windows test fix for 15221 (Closed)

Created:
7 years, 6 months ago by dcarney

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

windows test fix for 15221 TBR=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15232

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/x64/stub-cache-x64.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dcarney

Committed patchset #1 manually as r15232 (presubmit successful).

7 years, 6 months ago (2013-06-20 11:03:13 UTC) #1

Sven Panne

7 years, 6 months ago (2013-06-20 11:51:16 UTC) #2

Message was sent while issue was closed.

LGTM, although I couldn't actually verify that there is no register clash after
browsing through tons of functions. :-P Register allocation by hand is fun and
totally safe! ;-)

Expand Messages | Collapse Messages