Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 16831020: windows test fix for 15221 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1297 matching lines...) Expand 10 before | Expand all | Expand 10 after
1308 representation); 1308 representation);
1309 GenerateTailCall(masm(), stub.GetCode(isolate())); 1309 GenerateTailCall(masm(), stub.GetCode(isolate()));
1310 } 1310 }
1311 } 1311 }
1312 1312
1313 1313
1314 void BaseLoadStubCompiler::GenerateLoadCallback( 1314 void BaseLoadStubCompiler::GenerateLoadCallback(
1315 Register reg, 1315 Register reg,
1316 Handle<ExecutableAccessorInfo> callback) { 1316 Handle<ExecutableAccessorInfo> callback) {
1317 // Insert additional parameters into the stack frame above return address. 1317 // Insert additional parameters into the stack frame above return address.
1318 ASSERT(!scratch2().is(reg)); 1318 ASSERT(!scratch4().is(reg));
1319 __ pop(scratch2()); // Get return address to place it below. 1319 __ pop(scratch4()); // Get return address to place it below.
1320 1320
1321 __ push(receiver()); // receiver 1321 __ push(receiver()); // receiver
1322 __ push(reg); // holder 1322 __ push(reg); // holder
1323 if (heap()->InNewSpace(callback->data())) { 1323 if (heap()->InNewSpace(callback->data())) {
1324 __ Move(scratch1(), callback); 1324 __ Move(scratch1(), callback);
1325 __ push(FieldOperand(scratch1(), 1325 __ push(FieldOperand(scratch1(),
1326 ExecutableAccessorInfo::kDataOffset)); // data 1326 ExecutableAccessorInfo::kDataOffset)); // data
1327 } else { 1327 } else {
1328 __ Push(Handle<Object>(callback->data(), isolate())); 1328 __ Push(Handle<Object>(callback->data(), isolate()));
1329 } 1329 }
(...skipping 17 matching lines...) Expand all
1347 // Win64 uses first register--rcx--for returned value. 1347 // Win64 uses first register--rcx--for returned value.
1348 Register getter_arg = returns_handle ? r9 : r8; 1348 Register getter_arg = returns_handle ? r9 : r8;
1349 Register accessor_info_arg = returns_handle ? r8 : rdx; 1349 Register accessor_info_arg = returns_handle ? r8 : rdx;
1350 Register name_arg = returns_handle ? rdx : rcx; 1350 Register name_arg = returns_handle ? rdx : rcx;
1351 #else 1351 #else
1352 Register getter_arg = rdx; 1352 Register getter_arg = rdx;
1353 Register accessor_info_arg = rsi; 1353 Register accessor_info_arg = rsi;
1354 Register name_arg = rdi; 1354 Register name_arg = rdi;
1355 #endif 1355 #endif
1356 1356
1357 ASSERT(!name_arg.is(scratch2())); 1357 ASSERT(!name_arg.is(scratch4()));
1358 __ movq(name_arg, rsp); 1358 __ movq(name_arg, rsp);
1359 __ push(scratch2()); // Restore return address. 1359 __ push(scratch4()); // Restore return address.
1360 1360
1361 // v8::Arguments::values_ and handler for name. 1361 // v8::Arguments::values_ and handler for name.
1362 const int kStackSpace = PropertyCallbackArguments::kArgsLength + 1; 1362 const int kStackSpace = PropertyCallbackArguments::kArgsLength + 1;
1363 1363
1364 // Allocate v8::AccessorInfo in non-GCed stack space. 1364 // Allocate v8::AccessorInfo in non-GCed stack space.
1365 const int kArgStackSpace = 1; 1365 const int kArgStackSpace = 1;
1366 1366
1367 __ PrepareCallApiFunction(kArgStackSpace, returns_handle); 1367 __ PrepareCallApiFunction(kArgStackSpace, returns_handle);
1368 STATIC_ASSERT(PropertyCallbackArguments::kArgsLength == 6); 1368 STATIC_ASSERT(PropertyCallbackArguments::kArgsLength == 6);
1369 __ lea(rax, Operand(name_arg, 6 * kPointerSize)); 1369 __ lea(rax, Operand(name_arg, 6 * kPointerSize));
(...skipping 2202 matching lines...) Expand 10 before | Expand all | Expand 10 after
3572 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3572 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3573 } 3573 }
3574 } 3574 }
3575 3575
3576 3576
3577 #undef __ 3577 #undef __
3578 3578
3579 } } // namespace v8::internal 3579 } } // namespace v8::internal
3580 3580
3581 #endif // V8_TARGET_ARCH_X64 3581 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698