Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1682973004: Enable ImageGenerator tests on direct raster and direct gpu backends (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M dm/DMSrcSink.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
msarett
4 years, 10 months ago (2016-02-10 14:05:06 UTC) #3
djsollen
lgtm https://codereview.chromium.org/1682973004/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/1682973004/diff/1/dm/DMSrcSink.cpp#newcode274 dm/DMSrcSink.cpp:274: return (flags.type != SinkFlags::kRaster && flags.type != SinkFlags::kGPU) ...
4 years, 10 months ago (2016-02-10 14:10:54 UTC) #4
msarett
https://codereview.chromium.org/1682973004/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/1682973004/diff/1/dm/DMSrcSink.cpp#newcode274 dm/DMSrcSink.cpp:274: return (flags.type != SinkFlags::kRaster && flags.type != SinkFlags::kGPU) || ...
4 years, 10 months ago (2016-02-10 14:14:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682973004/20001
4 years, 10 months ago (2016-02-10 14:14:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/36c070d82856bd79eaa13bd058af45e19f302b53
4 years, 10 months ago (2016-02-10 14:48:25 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 14:48:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/36c070d82856bd79eaa13bd058af45e19f302b53

Powered by Google App Engine
This is Rietveld 408576698