Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: dm/DMSrcSink.cpp

Issue 1682973004: Enable ImageGenerator tests on direct raster and direct gpu backends (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMSrcSink.cpp
diff --git a/dm/DMSrcSink.cpp b/dm/DMSrcSink.cpp
index 1e323cbdee5208b668302b70070a2adbc2aaf678..9a623620101f57afedf49b596fe909f7038bd32a 100644
--- a/dm/DMSrcSink.cpp
+++ b/dm/DMSrcSink.cpp
@@ -271,7 +271,9 @@ CodecSrc::CodecSrc(Path path, Mode mode, DstColorType dstColorType, SkAlphaType
bool CodecSrc::veto(SinkFlags flags) const {
// Test CodecImageGenerator on 8888, 565, and gpu
if (kGen_Mode == fMode) {
- return flags.type != SinkFlags::kRaster || flags.type != SinkFlags::kGPU ||
+ // For image generator, we want to test kDirect approaches for kRaster and kGPU,
+ // while skipping everything else.
+ return (flags.type != SinkFlags::kRaster && flags.type != SinkFlags::kGPU) ||
flags.approach != SinkFlags::kDirect;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698