Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1682953002: Sk4f: floor() via int32_t roundtrip. (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk4f: floor() via int32_t roundtrip. About 25% faster on both x86 and ARMv7. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1682953002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/e5fe9a42d487c8648101c6f8454575d6de1acafa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M src/opts/SkNx_neon.h View 1 chunk +6 lines, -7 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mtklein_C
4 years, 10 months ago (2016-02-09 21:51:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682953002/1
4 years, 10 months ago (2016-02-09 21:51:33 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-09 21:51:34 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 10 months ago (2016-02-10 03:51:09 UTC) #9
herb_g
lgtm
4 years, 10 months ago (2016-02-10 15:47:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682953002/1
4 years, 10 months ago (2016-02-10 15:55:11 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 15:56:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e5fe9a42d487c8648101c6f8454575d6de1acafa

Powered by Google App Engine
This is Rietveld 408576698