src/debug/arm/debug-arm.cc - Issue 1682853003: [debugger] introduce abstract interface for break location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/arm/debug-arm.cc

Issue 1682853003: [debugger] introduce abstract interface for break location. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: revert stray edit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/arm/debug-arm.cc

diff --git a/src/debug/arm/debug-arm.cc b/src/debug/arm/debug-arm.cc

index 2d4cbf13d76ddd145760f7be49d80f82a9bf344d..5fdda4fedc34144011441d4165f8db5372f78489 100644

--- a/src/debug/arm/debug-arm.cc

+++ b/src/debug/arm/debug-arm.cc

@@ -62,6 +62,10 @@ void DebugCodegen::PatchDebugBreakSlot(Isolate* isolate, Address pc,

patcher.masm()->blx(ip);

}

+bool DebugCodegen::DebugBreakSlotIsPatched(Address pc) {

+ Instr current_instr = Assembler::instr_at(pc);

+ return !Assembler::IsNop(current_instr, Assembler::DEBUG_BREAK_NOP);

void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm,

DebugBreakCallHelperMode mode) {

« no previous file with comments | « src/assembler.cc ('k') | src/debug/arm64/debug-arm64.cc » ('j') | no next file with comments »