Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/debug/arm/debug-arm.cc

Issue 1682853003: [debugger] introduce abstract interface for break location. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: revert stray edit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/debug/arm64/debug-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // skip: 55 // skip:
56 // blx ip 56 // blx ip
57 Label skip_constant; 57 Label skip_constant;
58 patcher.masm()->ldr(ip, MemOperand(v8::internal::pc, 0)); 58 patcher.masm()->ldr(ip, MemOperand(v8::internal::pc, 0));
59 patcher.masm()->b(&skip_constant); 59 patcher.masm()->b(&skip_constant);
60 patcher.Emit(code->entry()); 60 patcher.Emit(code->entry());
61 patcher.masm()->bind(&skip_constant); 61 patcher.masm()->bind(&skip_constant);
62 patcher.masm()->blx(ip); 62 patcher.masm()->blx(ip);
63 } 63 }
64 64
65 bool DebugCodegen::DebugBreakSlotIsPatched(Address pc) {
66 Instr current_instr = Assembler::instr_at(pc);
67 return !Assembler::IsNop(current_instr, Assembler::DEBUG_BREAK_NOP);
68 }
65 69
66 void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm, 70 void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm,
67 DebugBreakCallHelperMode mode) { 71 DebugBreakCallHelperMode mode) {
68 __ RecordComment("Debug break"); 72 __ RecordComment("Debug break");
69 { 73 {
70 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL); 74 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
71 75
72 // Load padding words on stack. 76 // Load padding words on stack.
73 __ mov(ip, Operand(Smi::FromInt(LiveEdit::kFramePaddingValue))); 77 __ mov(ip, Operand(Smi::FromInt(LiveEdit::kFramePaddingValue)));
74 for (int i = 0; i < LiveEdit::kFramePaddingInitialSize; i++) { 78 for (int i = 0; i < LiveEdit::kFramePaddingInitialSize; i++) {
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 148
145 149
146 const bool LiveEdit::kFrameDropperSupported = true; 150 const bool LiveEdit::kFrameDropperSupported = true;
147 151
148 #undef __ 152 #undef __
149 153
150 } // namespace internal 154 } // namespace internal
151 } // namespace v8 155 } // namespace v8
152 156
153 #endif // V8_TARGET_ARCH_ARM 157 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/assembler.cc ('k') | src/debug/arm64/debug-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698