Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: src/effects/SkResizeImageFilter.cpp

Issue 168283006: Fix CTM application in SkResizeImagefilter; implement bounds traversals. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Simplify imageresizetiled GM a tad (layerBounds are useless) Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/effects/SkResizeImageFilter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/SkResizeImageFilter.cpp
diff --git a/src/effects/SkResizeImageFilter.cpp b/src/effects/SkResizeImageFilter.cpp
index 4a3f4b56ee62022e4dbc24c4a646db025ff7c989..51c1d6d6b402caebb0f7c92022daf06a516e8afb 100644
--- a/src/effects/SkResizeImageFilter.cpp
+++ b/src/effects/SkResizeImageFilter.cpp
@@ -42,12 +42,12 @@ SkResizeImageFilter::~SkResizeImageFilter() {
bool SkResizeImageFilter::onFilterImage(Proxy* proxy,
const SkBitmap& source,
- const SkMatrix& matrix,
+ const SkMatrix& ctm,
SkBitmap* result,
SkIPoint* offset) const {
SkBitmap src = source;
SkIPoint srcOffset = SkIPoint::Make(0, 0);
- if (getInput(0) && !getInput(0)->filterImage(proxy, source, matrix, &src, &srcOffset)) {
+ if (getInput(0) && !getInput(0)->filterImage(proxy, source, ctm, &src, &srcOffset)) {
return false;
}
@@ -56,9 +56,13 @@ bool SkResizeImageFilter::onFilterImage(Proxy* proxy,
src.getBounds(&srcBounds);
srcBounds.offset(srcOffset);
SkRect srcRect = SkRect::Make(srcBounds);
- SkMatrix dstMatrix;
- dstMatrix.setScale(fSx, fSy);
- dstMatrix.mapRect(&dstRect, srcRect);
+ SkMatrix matrix;
+ if (!ctm.invert(&matrix)) {
+ return false;
+ }
+ matrix.postScale(fSx, fSy);
+ matrix.postConcat(ctm);
+ matrix.mapRect(&dstRect, srcRect);
dstRect.roundOut(&dstBounds);
SkAutoTUnref<SkBaseDevice> device(proxy->createDevice(dstBounds.width(), dstBounds.height()));
@@ -67,12 +71,11 @@ bool SkResizeImageFilter::onFilterImage(Proxy* proxy,
}
SkCanvas canvas(device.get());
- canvas.translate(-SkIntToScalar(dstBounds.fLeft), -SkIntToScalar(dstBounds.fTop));
+ canvas.scale(fSx, fSy);
SkPaint paint;
paint.setXfermodeMode(SkXfermode::kSrc_Mode);
paint.setFilterLevel(fFilterLevel);
- canvas.concat(dstMatrix);
canvas.drawBitmap(src, srcRect.left(), srcRect.top(), &paint);
*result = device.get()->accessBitmap(false);
@@ -80,3 +83,31 @@ bool SkResizeImageFilter::onFilterImage(Proxy* proxy,
offset->fY = dstBounds.fTop;
return true;
}
+
+void SkResizeImageFilter::computeFastBounds(const SkRect& src, SkRect* dst) const {
+ SkRect bounds = src;
+ if (getInput(0)) {
+ getInput(0)->computeFastBounds(src, &bounds);
+ }
+ dst->setXYWH(bounds.x(), bounds.y(), bounds.width() * fSx, bounds.height() * fSy);
+}
+
+bool SkResizeImageFilter::onFilterBounds(const SkIRect& src, const SkMatrix& ctm,
+ SkIRect* dst) const {
+ SkMatrix matrix;
+ if (!ctm.invert(&matrix)) {
+ return false;
+ }
+ matrix.postScale(SkScalarInvert(fSx), SkScalarInvert(fSy));
+ matrix.postConcat(ctm);
+ SkRect floatBounds;
+ matrix.mapRect(&floatBounds, SkRect::Make(src));
+ SkIRect bounds;
+ floatBounds.roundOut(&bounds);
+ if (getInput(0) && !getInput(0)->filterBounds(bounds, ctm, &bounds)) {
+ return false;
+ }
+
+ *dst = bounds;
+ return true;
+}
« no previous file with comments | « include/effects/SkResizeImageFilter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698