Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 168283006: Fix CTM application in SkResizeImagefilter; implement bounds traversals. (Closed)

Created:
6 years, 10 months ago by Stephen White
Modified:
6 years, 10 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix CTM application in SkResizeImagefilter; implement bounds traversals. SkResizeImageFilter resizes all the pixels from its input (subject to the input's crop rect), but the offset to be applied was incorrect. It should take the CTM into account, so that the origin of the resize is the world space origin, unaffected by whatever clipping is applied. New GM imageresizetiled exercises the behaviour under impl-side-painting-like conditions, and existing GMs now have resize cases added. R=reed@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=13506

Patch Set 1 #

Patch Set 2 : Updated to ToT #

Patch Set 3 : Embiggen result size for imagefiltersscaled; add suppressions to ignored-tests.txt. #

Total comments: 6

Patch Set 4 : Fixed nits #

Patch Set 5 : Simplify imageresizetiled GM a tad (layerBounds are useless) #

Patch Set 6 : Simplify imageresizetiled GM a tad (layerBounds are useless) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -27 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M gm/imagefiltersclipped.cpp View 1 3 chunks +9 lines, -1 line 0 comments Download
M gm/imagefiltersscaled.cpp View 1 2 4 chunks +8 lines, -1 line 0 comments Download
A + gm/imageresizetiled.cpp View 1 2 3 4 2 chunks +18 lines, -17 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkResizeImageFilter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/effects/SkResizeImageFilter.cpp View 4 chunks +38 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
Rob: PTAL. Thanks!
6 years, 10 months ago (2014-02-19 17:20:27 UTC) #1
robertphillips
lgtm + nits. https://codereview.chromium.org/168283006/diff/70001/gm/imageresizetiled.cpp File gm/imageresizetiled.cpp (right): https://codereview.chromium.org/168283006/diff/70001/gm/imageresizetiled.cpp#newcode24 gm/imageresizetiled.cpp:24: protected: SK_OVERRIDE on next 3? https://codereview.chromium.org/168283006/diff/70001/gm/imageresizetiled.cpp#newcode34 ...
6 years, 10 months ago (2014-02-19 19:42:01 UTC) #2
Stephen White
+bsalomon for API https://codereview.chromium.org/168283006/diff/70001/gm/imageresizetiled.cpp File gm/imageresizetiled.cpp (right): https://codereview.chromium.org/168283006/diff/70001/gm/imageresizetiled.cpp#newcode24 gm/imageresizetiled.cpp:24: protected: On 2014/02/19 19:42:01, robertphillips wrote: ...
6 years, 10 months ago (2014-02-19 20:32:44 UTC) #3
Stephen White
+reed for API (shamelessly trolling for reviewers)
6 years, 10 months ago (2014-02-19 21:42:53 UTC) #4
reed1
lgtm
6 years, 10 months ago (2014-02-19 22:04:13 UTC) #5
Stephen White
6 years, 10 months ago (2014-02-19 22:10:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 manually as r13506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698