Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1682813004: Revert of Add plumbing in blink to allow overriding the default font collection. (Closed)

Created:
4 years, 10 months ago by iclelland
Modified:
4 years, 10 months ago
CC:
jbroman, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, bungeman-skia, Rik, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jam, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add plumbing in blink to allow overriding the default font collection. (patchset #15 id:300001 of https://codereview.chromium.org/1591883002/ ) Reason for revert: This patch is breaking GPU builds -- See https://build.chromium.org/p/chromium.gpu/builders/GPU%20Win%20Builder/builds/37280 specifically. We're seeing the error: e:\b\build\slave\gpu_win_builder\build\src\third_party\webkit\source\platform\fonts\win\fontcacheskiawin.cpp(101) : error C3861: 'adopted': identifier not found Original issue's description: > Add plumbing in blink to allow overriding the skia font manager. This allows Chromium to use a custom font collection with skia, without having to patch the vtable of the DirectWrite factory. > > Note that this change depends on skia change https://codereview.chromium.org/1607083003/ which must land first. > > BUG= > > Committed: https://crrev.com/0e752e79260c775500c78cc351887fc19410bd8b > Cr-Commit-Position: refs/heads/master@{#374482} TBR=bungeman@chromium.org,dglazkov+blink@chromium.org,tfarina@chromium.org,bungeman@google.com,scottmg@chromium.org,pfeldman@chromium.org,kulshin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/94fb5d4a5bf05e7d230c29be6df8ea1a21628032 Cr-Commit-Position: refs/heads/master@{#374497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -44 lines) Patch
M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 3 chunks +22 lines, -9 lines 0 comments Download
M content/child/font_warmup_win.cc View 2 chunks +25 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/win/WebFontRendering.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/win/WebFontRendering.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
iclelland
Created Revert of Add plumbing in blink to allow overriding the default font collection.
4 years, 10 months ago (2016-02-09 22:10:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682813004/1
4 years, 10 months ago (2016-02-09 22:12:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 22:16:01 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 22:17:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94fb5d4a5bf05e7d230c29be6df8ea1a21628032
Cr-Commit-Position: refs/heads/master@{#374497}

Powered by Google App Engine
This is Rietveld 408576698