Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issue 1682793002: Slim down Sk4fRoundtrip benches. (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Slim down Sk4fRoundtrip benches. Looks like the conversions are complicated enough to not compile away. No need to mess with random number generation, etc. We still need to blackhole it into a volatile in the end. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1682793002 Committed: https://skia.googlesource.com/skia/+/77aa62c01ed412ddbcc5d02b842a7e2445b51e3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M bench/Sk4fBench.cpp View 3 chunks +8 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 10 months ago (2016-02-09 18:22:11 UTC) #3
herb_g
lgtm
4 years, 10 months ago (2016-02-09 18:37:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682793002/1
4 years, 10 months ago (2016-02-09 18:39:21 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 19:03:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/77aa62c01ed412ddbcc5d02b842a7e2445b51e3e

Powered by Google App Engine
This is Rietveld 408576698