Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1682703003: Add some backend flexibility for shader declarations in ProgramBuilding. (Closed)

Created:
4 years, 10 months ago by egdaniel
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add some backend flexibility for shader declarations in ProgramBuilding. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1682703003 Committed: https://skia.googlesource.com/skia/+/b80ec8b79c0a60a5a300870de838aa31bbc18cdd

Patch Set 1 #

Patch Set 2 : fix dtor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/gpu/gl/GrGLVaryingHandler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLVarying.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLVarying.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
egdaniel
4 years, 10 months ago (2016-02-09 16:43:36 UTC) #3
joshualitt
On 2016/02/09 16:43:36, egdaniel wrote: lgtm
4 years, 10 months ago (2016-02-09 16:48:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682703003/1
4 years, 10 months ago (2016-02-09 17:05:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/6016)
4 years, 10 months ago (2016-02-09 17:09:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682703003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682703003/20001
4 years, 10 months ago (2016-02-09 17:21:08 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 17:54:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b80ec8b79c0a60a5a300870de838aa31bbc18cdd

Powered by Google App Engine
This is Rietveld 408576698