Run WebGL 2.0 conformance tests in more cases.

tools/roll_webgl_conformance.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import collections
 import logging
 import os
 import re
 import subprocess
 import sys
 import time
 
 extra_trybots = [
   {
     "mastername": "tryserver.chromium.win",
-    "buildername": "win_clang_dbg",
+    "buildernames": ["win_optional_gpu_tests_rel"]
   }
 ]
 
 SCRIPT_DIR = os.path.dirname(os.path.realpath(__file__))
 SRC_DIR = os.path.abspath(os.path.join(SCRIPT_DIR, os.pardir))
 sys.path.insert(0, os.path.join(SRC_DIR, 'build'))
 import find_depot_tools
 find_depot_tools.add_depot_tools_to_path()
 import roll_dep_svn
 from gclient import GClientKeywords
 from third_party import upload
 
 # Avoid depot_tools/third_party/upload.py print verbose messages.
 upload.verbosity = 0  # Errors only.
 
 CHROMIUM_GIT_URL = 'https://chromium.googlesource.com/chromium/src.git'
 CL_ISSUE_RE = re.compile('^Issue number: ([0-9]+) \((.*)\)$')
 RIETVELD_URL_RE = re.compile('^https?://(.*)/(.*)')
-ROLL_BRANCH_NAME = 'special_angle_roll_branch'
+ROLL_BRANCH_NAME = 'special_webgl_roll_branch'
 TRYJOB_STATUS_SLEEP_SECONDS = 30
 
 # Use a shell for subcommands on Windows to get a PATH search.
 IS_WIN = sys.platform.startswith('win')
-ANGLE_PATH = os.path.join('third_party', 'angle')
+WEBGL_PATH = os.path.join('third_party', 'webgl', 'src')
 
 CommitInfo = collections.namedtuple('CommitInfo', ['git_commit',
                                                    'git_repo_url'])
 CLInfo = collections.namedtuple('CLInfo', ['issue', 'url', 'rietveld_server'])
 
 def _PosixPath(path):
   """Convert a possibly-Windows path to a posix-style path."""
   (_, path) = os.path.splitdrive(path)
   return path.replace(os.sep, '/')
 
@@ skipping 18 matching lines @@
   global_scope = {
     'File': GClientKeywords.FileImpl,
     'From': GClientKeywords.FromImpl,
     'Var': var.Lookup,
     'deps_os': {},
   }
   exec(deps_content, global_scope, local_scope)
   return local_scope
 
 
-def _GenerateCLDescriptionCommand(angle_current, angle_new, bugs):
+def _GenerateCLDescriptionCommand(webgl_current, webgl_new, bugs):
   def GetChangeString(current_hash, new_hash):
     return '%s..%s' % (current_hash[0:7], new_hash[0:7]);
 
   def GetChangeLogURL(git_repo_url, change_string):
     return '%s/+log/%s' % (git_repo_url, change_string)
 
   def GetBugString(bugs):
     bug_str = 'BUG='
     for bug in bugs:
       bug_str += str(bug) + ','
     return bug_str.rstrip(',')
 
-  if angle_current.git_commit != angle_new.git_commit:
-    change_str = GetChangeString(angle_current.git_commit,
-                                 angle_new.git_commit)
-    changelog_url = GetChangeLogURL(angle_current.git_repo_url,
+  if webgl_current.git_commit != webgl_new.git_commit:
+    change_str = GetChangeString(webgl_current.git_commit,
+                                 webgl_new.git_commit)
+    changelog_url = GetChangeLogURL(webgl_current.git_repo_url,
                                     change_str)
 
+  def GetExtraTrybotString():
+    s = ''
+    for t in extra_trybots:
+      if s:
+        s += ';'
+      s += t['mastername'] + ':' + ','.join(t['buildernames'])
+    return s
+
+  extra_trybot_args = []
+  if extra_trybots:
+    extra_trybot_string = GetExtraTrybotString()
+    extra_trybot_args = ['-m', 'CQ_INCLUDE_TRYBOTS=' + extra_trybot_string]
+
   return [
-    '-m', 'Roll ANGLE ' + change_str,
+    '-m', 'Roll WebGL ' + change_str,
     '-m', '%s' % changelog_url,
     '-m', GetBugString(bugs),
     '-m', 'TEST=bots',
-  ]
+  ] + extra_trybot_args
 
 
 class AutoRoller(object):
   def __init__(self, chromium_src):
     self._chromium_src = chromium_src
 
   def _RunCommand(self, command, working_dir=None, ignore_exit_code=False,
                   extra_env=None):
     """Runs a command and returns the stdout from that command.
 
@@ skipping 57 matching lines @@
 
   def _IsTreeClean(self):
     lines = self._RunCommand(
       ['git', 'status', '--porcelain', '-uno']).splitlines()
     if len(lines) == 0:
       return True
 
     logging.debug('Dirty/unversioned files:\n%s', '\n'.join(lines))
     return False
 
-  def _GetBugList(self, path_below_src, angle_current, angle_new):
+  def _GetBugList(self, path_below_src, webgl_current, webgl_new):
+    # TODO(kbr): this isn't useful, at least not yet, when run against
+    # the WebGL Github repository.
     working_dir = os.path.join(self._chromium_src, path_below_src)
     lines = self._RunCommand(
         ['git','log',
-            '%s..%s' % (angle_current.git_commit, angle_new.git_commit)],
+            '%s..%s' % (webgl_current.git_commit, webgl_new.git_commit)],
         working_dir=working_dir).split('\n')
     bugs = set()
     for line in lines:
       line = line.strip()
       bug_prefix = 'BUG='
       if line.startswith(bug_prefix):
         bugs_strings = line[len(bug_prefix):].split(',')
         for bug_string in bugs_strings:
           try:
             bugs.add(int(bug_string))
@@ skipping 31 matching lines @@
     if not ignore_checks:
       self._RunCommand(['git', 'pull'])
 
     self._RunCommand(['git', 'checkout', '-b', ROLL_BRANCH_NAME])
 
     # Modify Chromium's DEPS file.
 
     # Parse current hashes.
     deps_filename = os.path.join(self._chromium_src, 'DEPS')
     deps = _ParseDepsFile(deps_filename)
-    angle_current = self._GetDepsCommitInfo(deps, ANGLE_PATH)
+    webgl_current = self._GetDepsCommitInfo(deps, WEBGL_PATH)
 
     # Find ToT revisions.
-    angle_latest = self._GetCommitInfo(ANGLE_PATH)
+    webgl_latest = self._GetCommitInfo(WEBGL_PATH)
 
     if IS_WIN:
       # Make sure the roll script doesn't use windows line endings
       self._RunCommand(['git', 'config', 'core.autocrlf', 'true'])
 
-    self._UpdateDep(deps_filename, ANGLE_PATH, angle_latest)
+    self._UpdateDep(deps_filename, WEBGL_PATH, webgl_latest)
 
     if self._IsTreeClean():
       logging.debug('Tree is clean - no changes detected.')
       self._DeleteRollBranch()
     else:
-      bugs = self._GetBugList(ANGLE_PATH, angle_current, angle_latest)
+      bugs = self._GetBugList(WEBGL_PATH, webgl_current, webgl_latest)
       description = _GenerateCLDescriptionCommand(
-          angle_current, angle_latest, bugs)
+          webgl_current, webgl_latest, bugs)
       logging.debug('Committing changes locally.')
       self._RunCommand(['git', 'add', '--update', '.'])
       self._RunCommand(['git', 'commit'] + description)
       logging.debug('Uploading changes...')
       self._RunCommand(['git', 'cl', 'upload'],
                        extra_env={'EDITOR': 'true'})
 
-      # Run the default trybots
+      # Kick off tryjobs.
       base_try_cmd = ['git', 'cl', 'try']
       self._RunCommand(base_try_cmd)
 
       if extra_trybots:
-        # Run additional tryjobs
-        extra_try_args = []
-        for extra_trybot in extra_trybots:
-          extra_try_args += ['-m', extra_trybot["mastername"],
-                             '-b', extra_trybot["buildername"]]
-        self._RunCommand(base_try_cmd + extra_try_args)
+        # Run additional tryjobs.
+        # TODO(kbr): this should not be necessary -- the
+        # CQ_INCLUDE_TRYBOTS directive above should handle it.
+        # http://crbug.com/585237
+        for trybot in extra_trybots:
+          for builder in trybot['buildernames']:
+            self._RunCommand(base_try_cmd + [
+                '-m', trybot['mastername'],
+                '-b', builder])
 
       cl_info = self._GetCLInfo()
       print 'Issue: %d URL: %s' % (cl_info.issue, cl_info.url)
 
     # Checkout master again.
     self._RunCommand(['git', 'checkout', 'master'])
     print 'Roll branch left as ' + ROLL_BRANCH_NAME
     return 0
 
   def _UpdateDep(self, deps_filename, dep_relative_to_src, commit_info):
@@ skipping 42 matching lines @@
       self._RunCommand(['git', 'checkout', ROLL_BRANCH_NAME])
       # Ignore an error here in case an issue wasn't created for some reason.
       self._RunCommand(['git', 'cl', 'set_close'], ignore_exit_code=True)
       self._RunCommand(['git', 'checkout', active_branch])
       self._RunCommand(['git', 'branch', '-D', ROLL_BRANCH_NAME])
     return 0
 
 
 def main():
   parser = argparse.ArgumentParser(
-      description='Auto-generates a CL containing an ANGLE roll.')
+      description='Auto-generates a CL containing a WebGL conformance roll.')
   parser.add_argument('--abort',
     help=('Aborts a previously prepared roll. '
           'Closes any associated issues and deletes the roll branches'),
     action='store_true')
   parser.add_argument('--ignore-checks', action='store_true', default=False,
       help=('Skips checks for being on the master branch, dirty workspaces and '
             'the updating of the checkout. Will still delete and create local '
             'Git branches.'))
   parser.add_argument('-v', '--verbose', action='store_true', default=False,
       help='Be extra verbose in printing of log messages.')
   args = parser.parse_args()
 
   if args.verbose:
     logging.basicConfig(level=logging.DEBUG)
   else:
     logging.basicConfig(level=logging.ERROR)
 
   autoroller = AutoRoller(SRC_DIR)
   if args.abort:
     return autoroller.Abort()
   else:
     return autoroller.PrepareRoll(args.ignore_checks)
 
 if __name__ == '__main__':
   sys.exit(main())