Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1682343003: Add abort-on-assertion flag to dart2js unit test runner. (Closed)

Created:
4 years, 10 months ago by Bill Hesse
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add abort-on-assertion flag to dart2js unit test runner. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/b42443bd260680479dfc5cf5de558f133dfb17b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/bots/compiler.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 10 months ago (2016-02-10 12:18:41 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 10 months ago (2016-02-10 12:39:44 UTC) #3
Bill Hesse
4 years, 10 months ago (2016-02-10 12:42:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b42443bd260680479dfc5cf5de558f133dfb17b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698