Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: tools/bots/compiler.py

Issue 1682343003: Add abort-on-assertion flag to dart2js unit test runner. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 3 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
4 # for details. All rights reserved. Use of this source code is governed by a 4 # for details. All rights reserved. Use of this source code is governed by a
5 # BSD-style license that can be found in the LICENSE file. 5 # BSD-style license that can be found in the LICENSE file.
6 6
7 """ 7 """
8 Dart2js buildbot steps 8 Dart2js buildbot steps
9 9
10 Runs tests for the dart2js compiler. 10 Runs tests for the dart2js compiler.
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 output = output.split() 272 output = output.split()
273 try: 273 try:
274 print 'Version of %s: %s' % (runtime, output[-1]) 274 print 'Version of %s: %s' % (runtime, output[-1])
275 except IndexError: 275 except IndexError:
276 # Failed to obtain version information. Continue running tests. 276 # Failed to obtain version information. Continue running tests.
277 pass 277 pass
278 278
279 unit_test_flags = [flag for flag in flags if flag.startswith('--shard')] 279 unit_test_flags = [flag for flag in flags if flag.startswith('--shard')]
280 # Run the unit tests in checked mode (the VM's checked mode). 280 # Run the unit tests in checked mode (the VM's checked mode).
281 unit_test_flags.append('--checked') 281 unit_test_flags.append('--checked')
282 unit_test_flags.append('--vm-options=--abort-on-assertion-errors')
282 if runtime == 'd8': 283 if runtime == 'd8':
283 # The dart2js compiler isn't self-hosted (yet) so we run its 284 # The dart2js compiler isn't self-hosted (yet) so we run its
284 # unit tests on the VM. We avoid doing this on the builders 285 # unit tests on the VM. We avoid doing this on the builders
285 # that run the browser tests to cut down on the cycle time. 286 # that run the browser tests to cut down on the cycle time.
286 TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js', 'try'], 287 TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js', 'try'],
287 unit_test_flags, arch) 288 unit_test_flags, arch)
288 289
289 if compiler == 'dart2js' and runtime == 'drt': 290 if compiler == 'dart2js' and runtime == 'drt':
290 # Ensure that we run the "try" tests on Content Shell. 291 # Ensure that we run the "try" tests on Content Shell.
291 TestStep("incremental_compilation", mode, system, 'none', runtime, 292 TestStep("incremental_compilation", mode, system, 'none', runtime,
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 if build_info.mode == 'debug': 413 if build_info.mode == 'debug':
413 target = 'dart2js_bot_debug' 414 target = 'dart2js_bot_debug'
414 args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode, 415 args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode,
415 '--arch=' + build_info.arch, target] 416 '--arch=' + build_info.arch, target]
416 print 'Build SDK and d8: %s' % (' '.join(args)) 417 print 'Build SDK and d8: %s' % (' '.join(args))
417 bot.RunProcess(args) 418 bot.RunProcess(args)
418 419
419 420
420 if __name__ == '__main__': 421 if __name__ == '__main__':
421 bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler) 422 bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698