content/common/gpu/media/android_deferred_rendering_backing_strategy.h - Issue 1682343002: AVDACodecImages keep a reference to the SurfaceTexture backing them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/android_deferred_rendering_backing_strategy.h

Issue 1682343002: AVDACodecImages keep a reference to the SurfaceTexture backing them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/common/gpu/media/android_deferred_rendering_backing_strategy.cc » ('j') | content/common/gpu/media/android_deferred_rendering_backing_strategy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/android_deferred_rendering_backing_strategy.h

diff --git a/content/common/gpu/media/android_deferred_rendering_backing_strategy.h b/content/common/gpu/media/android_deferred_rendering_backing_strategy.h

index 4b8bd6d19e2845fd16e23b346b9aa63d992024fe..90a41cd6004913b39abc262bb3b9df225699be91 100644

--- a/content/common/gpu/media/android_deferred_rendering_backing_strategy.h

+++ b/content/common/gpu/media/android_deferred_rendering_backing_strategy.h

@@ -27,9 +27,9 @@ class AVDACodecImage;

class AVDASharedState;

// A BackingStrategy implementation that defers releasing codec buffers until

-// a PictureBuffer's texture is used to draw, then draws using the surface

-// texture's front buffer rather than a copy. To do this, it uses a GLImage

-// implementation to talk to MediaCodec.

+// a PictureBuffer's texture is used to draw. To do this it backs PictureBuffers

+// with AVDACodecImages, which talk to MediaCodec to organize the display of the

+// right frame. It can render to either a SurfaceTexture or SurfaceView Surface.

class CONTENT_EXPORT AndroidDeferredRenderingBackingStrategy

: public AndroidVideoDecodeAccelerator::BackingStrategy {

public: