Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1682183002: Remove PerAppSettingsService (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PerAppSettingsService Was only required for different |HostDesktopType|s which are being removed. R=benwells@chromium.org BUG=558054 Committed: https://crrev.com/9017a43db41052ac7f4104ff8bbd216fc35849a7 Cr-Commit-Position: refs/heads/master@{#374789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -188 lines) Patch
D chrome/browser/apps/per_app_settings_service.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/apps/per_app_settings_service.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/apps/per_app_settings_service_factory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/apps/per_app_settings_service_factory.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (10 generated)
scottmg
4 years, 10 months ago (2016-02-09 21:13:57 UTC) #3
scottmg
->asargent for timezone-y-ness
4 years, 10 months ago (2016-02-10 19:24:30 UTC) #5
asargent_no_longer_on_chrome
lgtm, however I'm not in chrome/browser/ui/views/apps/OWNERS so you still want to either wait for benwells/tapted ...
4 years, 10 months ago (2016-02-10 22:06:22 UTC) #6
scottmg
Oh right, thanks. +tapted for chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc.
4 years, 10 months ago (2016-02-10 22:21:03 UTC) #8
scottmg
Actually, the code in there was already unused, so I'm just going to tbr. But ...
4 years, 10 months ago (2016-02-10 22:37:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682183002/1
4 years, 10 months ago (2016-02-10 22:39:27 UTC) #12
tapted
nice :) lgtm (although I guess you still need benwells for application_launch.cc)
4 years, 10 months ago (2016-02-10 22:52:38 UTC) #13
scottmg
Oh, geez, oops. Ok, I guess you get to take a look after all Ben.
4 years, 10 months ago (2016-02-10 23:03:41 UTC) #15
benwells
lgtm sorry about delay, yesterday was a write off...
4 years, 10 months ago (2016-02-10 23:05:38 UTC) #16
scottmg
On 2016/02/10 23:05:38, benwells wrote: > lgtm > > sorry about delay, yesterday was a ...
4 years, 10 months ago (2016-02-10 23:21:59 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 23:48:10 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:48 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9017a43db41052ac7f4104ff8bbd216fc35849a7
Cr-Commit-Position: refs/heads/master@{#374789}

Powered by Google App Engine
This is Rietveld 408576698