mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl ('k') | mojo/ui/gl_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index 6ff277a12f4207ba2d8b648f3ee11a50d8c5bb55..38488cf807f626002a1e087d8ff80dda6e8e2b15 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -142,7 +142,7 @@ def GetCppResultWrapperType(kind):

return "mojo::Map<%s, %s>" % (GetCppArrayArgWrapperType(kind.key_kind),

GetCppArrayArgWrapperType(kind.value_kind))

if mojom.IsInterfaceKind(kind):

- return "%sPtr" % GetNameForKind(kind)

+ return "mojo::InterfaceHandle<%s>" % GetNameForKind(kind)

if mojom.IsInterfaceRequestKind(kind):

return "mojo::InterfaceRequest<%s>" % GetNameForKind(kind.kind)

if mojom.IsStringKind(kind):

@@ -170,7 +170,7 @@ def GetCppWrapperType(kind):

return "mojo::Map<%s, %s>" % (GetCppArrayArgWrapperType(kind.key_kind),

GetCppArrayArgWrapperType(kind.value_kind))

if mojom.IsInterfaceKind(kind):

- return "%sPtr" % GetNameForKind(kind)

+ return "mojo::InterfaceHandle<%s>" % GetNameForKind(kind)

if mojom.IsInterfaceRequestKind(kind):

return "mojo::InterfaceRequest<%s>" % GetNameForKind(kind.kind)

if mojom.IsStringKind(kind):

@@ -196,7 +196,7 @@ def GetCppConstWrapperType(kind):

return "mojo::Map<%s, %s>" % (GetCppArrayArgWrapperType(kind.key_kind),

GetCppArrayArgWrapperType(kind.value_kind))

if mojom.IsInterfaceKind(kind):

- return "%sPtr" % GetNameForKind(kind)

+ return "mojo::InterfaceHandle<%s>" % GetNameForKind(kind)

if mojom.IsInterfaceRequestKind(kind):

return "mojo::InterfaceRequest<%s>" % GetNameForKind(kind.kind)

if mojom.IsEnumKind(kind):