mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

index fde27aa7955271aeefd270ac4737da9cb5f77230..532a8f8cad9683fe15bf9bf2e0fa63824c3b4468 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

@@ -91,7 +91,7 @@ mojo::internal::ValidationError SerializeUnion_(

mojo::internal::Interface_Data* {{field.name}} =

reinterpret_cast<mojo::internal::Interface_Data*>(

&result->data.f_{{field.name}});

- mojo::internal::InterfacePointerToData(

+ mojo::internal::InterfaceHandleToData(

input_acc.data()->{{field.name}}->Pass(), {{field.name}});

{% elif field.kind|is_enum_kind %}

result->data.f_{{field.name}} =

@@ -144,7 +144,7 @@ void Deserialize_(internal::{{union.name}}_Data* input,

mojo::internal::Interface_Data* {{field.name}}_in =

reinterpret_cast<mojo::internal::Interface_Data*>(

&input->data.f_{{field.name}});

- mojo::internal::InterfaceDataToPointer(

+ mojo::internal::InterfaceDataToHandle(

{{field.name}}_in, &{{field.name}}_out);

output->set_{{field.name}}({{field.name}}_out.Pass());

{% elif field.kind|is_enum_kind %}