Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: mojo/common/trace_provider_impl.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/common/trace_provider_impl.h ('k') | mojo/gles2/command_buffer_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/trace_provider_impl.cc
diff --git a/mojo/common/trace_provider_impl.cc b/mojo/common/trace_provider_impl.cc
index 1e61f62f887b2b5e883acf452750f799375c3f15..cda6b6195d721c8dcb43a7a6fd7cef60bf6e392d 100644
--- a/mojo/common/trace_provider_impl.cc
+++ b/mojo/common/trace_provider_impl.cc
@@ -4,6 +4,8 @@
#include "mojo/common/trace_provider_impl.h"
+#include <utility>
+
#include "base/callback.h"
#include "base/logging.h"
#include "base/memory/weak_ptr.h"
@@ -28,10 +30,11 @@ void TraceProviderImpl::Bind(InterfaceRequest<tracing::TraceProvider> request) {
}
}
-void TraceProviderImpl::StartTracing(const String& categories,
- tracing::TraceRecorderPtr recorder) {
+void TraceProviderImpl::StartTracing(
+ const String& categories,
+ mojo::InterfaceHandle<tracing::TraceRecorder> recorder) {
DCHECK(!recorder_.get());
- recorder_ = recorder.Pass();
+ recorder_ = tracing::TraceRecorderPtr::Create(std::move(recorder));
tracing_forced_ = false;
if (!base::trace_event::TraceLog::GetInstance()->IsEnabled()) {
std::string categories_str = categories.To<std::string>();
« no previous file with comments | « mojo/common/trace_provider_impl.h ('k') | mojo/gles2/command_buffer_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698