mojo/common/trace_provider_impl.h - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/trace_provider_impl.h

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase ontop of master, address trung's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/common/trace_provider_impl.h

diff --git a/mojo/common/trace_provider_impl.h b/mojo/common/trace_provider_impl.h

index a1864ff1e6619a670ed811e0fe43174b3038f0cb..217ec7a99d41d82e1f9dd1cde7cb14d44c1504c6 100644

--- a/mojo/common/trace_provider_impl.h

+++ b/mojo/common/trace_provider_impl.h

@@ -26,8 +26,9 @@ class TraceProviderImpl : public tracing::TraceProvider {

private:

// tracing::TraceProvider implementation:

- void StartTracing(const String& categories,

- tracing::TraceRecorderPtr recorder) override;

+ void StartTracing(

+ const String& categories,

+ mojo::InterfaceHandle<tracing::TraceRecorder> recorder) override;

void StopTracing() override;

void SendChunk(const scoped_refptr<base::RefCountedString>& events_str,

« no previous file with comments | « examples/ui/tile/tile_app.cc ('k') | mojo/common/trace_provider_impl.cc » ('j') | no next file with comments »