Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: services/gfx/compositor/compositor_impl.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: delay InterfacePtr::Create() until you actually need an InterfacePtr. GetProxy() and ConnectToAppl… Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/gfx/compositor/compositor_impl.cc
diff --git a/services/gfx/compositor/compositor_impl.cc b/services/gfx/compositor/compositor_impl.cc
index 5d140030fc665fd31aa9fba01a64f65cc068fe01..dbf3eac2ad65af1b9ec09d0385c20abc1b48133e 100644
--- a/services/gfx/compositor/compositor_impl.cc
+++ b/services/gfx/compositor/compositor_impl.cc
@@ -4,6 +4,8 @@
#include "services/gfx/compositor/compositor_impl.h"
+#include <utility>
+
#include "services/gfx/compositor/scene_impl.h"
namespace compositor {
@@ -22,11 +24,12 @@ void CompositorImpl::CreateScene(
}
void CompositorImpl::CreateRenderer(
- mojo::ContextProviderPtr context_provider,
+ mojo::InterfaceHandle<mojo::ContextProvider> context_provider,
mojo::InterfaceRequest<mojo::gfx::composition::Renderer> renderer_request,
const mojo::String& label) {
- engine_->CreateRenderer(context_provider.Pass(), renderer_request.Pass(),
- label);
+ engine_->CreateRenderer(
viettrungluu 2016/02/11 18:26:29 Why doesn't CompositorEnginer::CreateRenderer() ta
vardhan 2016/02/11 22:47:53 Done.
+ mojo::ContextProviderPtr::Create(std::move(context_provider)),
+ renderer_request.Pass(), label);
}
} // namespace compositor

Powered by Google App Engine
This is Rietveld 408576698