services/gfx/compositor/graph/scene_def.cc - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/gfx/compositor/graph/scene_def.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delay InterfacePtr::Create() until you actually need an InterfacePtr. GetProxy() and ConnectToAppl… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« services/gfx/compositor/compositor_impl.cc ('K') | « services/gfx/compositor/compositor_impl.cc ('k') | services/gfx/compositor/scene_impl.h » ('j') | services/gfx/compositor/scene_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/gfx/compositor/graph/scene_def.cc

diff --git a/services/gfx/compositor/graph/scene_def.cc b/services/gfx/compositor/graph/scene_def.cc

index ae772737b1bf24a4d6ab926e66264adaa245e7f0..a23c1088a2376bb4d1a43442fe92e1a62f808248 100644

--- a/services/gfx/compositor/graph/scene_def.cc

+++ b/services/gfx/compositor/graph/scene_def.cc

@@ -5,6 +5,7 @@

#include "services/gfx/compositor/graph/scene_def.h"

#include <ostream>

+#include <utility>

#include "base/bind.h"

#include "base/logging.h"

@@ -292,7 +293,9 @@ ResourceDef* SceneDef::CreateResource(

base::MessageLoop::current()->task_runner(),

base::Bind(

&ReleaseMailboxTexture,

- base::Passed(mailbox_texture_resource_decl->callback.Pass())));

+ base::Passed(

+ mojo::gfx::composition::MailboxTextureCallbackPtr::Create(

+ std::move(mailbox_texture_resource_decl->callback)))));

if (!image) {

err << "Could not create MailboxTexture";

return nullptr;