Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1681943002: [counter] Properly measure own-time of runtime counters. (Closed)

Created:
4 years, 10 months ago by Camillo Bruni
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@2016-02-08_builtins_timer_1678973002
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counter] Properly measure own-time of runtime counters. By keeping track of the stack of counters we can properly subtract the subcounter times and properly measure the own-time spent in each runtime function. This is useful to get more details for builtins like HandleApiCall which are typical top-level entries for chome which previously prevent measurements of sub-calls to builtins/runtime functions. BUG= Committed: https://crrev.com/0949bce524ef010707c1ec5c5effada7224d9305 Cr-Commit-Position: refs/heads/master@{#33901}

Patch Set 1 #

Patch Set 2 : merging with master #

Patch Set 3 : fixing type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -58 lines) Patch
M src/arguments.h View 1 1 chunk +17 lines, -22 lines 0 comments Download
M src/builtins.cc View 1 1 chunk +6 lines, -11 lines 0 comments Download
M src/counters.h View 1 2 1 chunk +21 lines, -9 lines 0 comments Download
M src/counters.cc View 3 chunks +32 lines, -16 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
Camillo Bruni
Hi Jar, PTAL. I added support for proper own-time calculation, since under chrome the majority ...
4 years, 10 months ago (2016-02-09 13:15:18 UTC) #3
Jarin
lgtm. Thanks for doing this properly!
4 years, 10 months ago (2016-02-10 10:31:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681943002/1
4 years, 10 months ago (2016-02-11 13:21:11 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/10238)
4 years, 10 months ago (2016-02-11 13:27:31 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681943002/40001
4 years, 10 months ago (2016-02-11 13:48:29 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 14:35:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681943002/40001
4 years, 10 months ago (2016-02-11 14:36:16 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-11 14:49:03 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 14:49:40 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0949bce524ef010707c1ec5c5effada7224d9305
Cr-Commit-Position: refs/heads/master@{#33901}

Powered by Google App Engine
This is Rietveld 408576698