Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 1678973002: [counters] moving runtime counters to counter.h (Closed)

Created:
4 years, 10 months ago by Camillo Bruni
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counters] moving runtime counters to counter.h Additionally list C++ builtins as well under --runtime_call_stats. Let's try to keep all counters in one place, that makes it a bit easier to maintain and especially discard unused ones. BUG= Committed: https://crrev.com/6bc71431995d49d4ca4a2ea9c75e5add5f345225 Cr-Commit-Position: refs/heads/master@{#33847} Committed: https://crrev.com/e35554214902d68a76ad5858e2b86787f72834a5 Cr-Commit-Position: refs/heads/master@{#33893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -128 lines) Patch
M src/arguments.h View 1 chunk +22 lines, -24 lines 0 comments Download
M src/builtins.cc View 1 chunk +17 lines, -1 line 0 comments Download
M src/counters.h View 4 chunks +29 lines, -0 lines 0 comments Download
M src/counters.cc View 2 chunks +101 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/runtime/runtime.cc View 2 chunks +0 lines, -76 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (10 generated)
Camillo Bruni
Hi Jaro, PTAL. I moved your runtime counters
4 years, 10 months ago (2016-02-08 19:50:30 UTC) #2
Jarin
lgtm. Thanks!
4 years, 10 months ago (2016-02-09 07:02:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678973002/1
4 years, 10 months ago (2016-02-09 08:45:56 UTC) #6
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-09 09:30:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678973002/1
4 years, 10 months ago (2016-02-09 13:12:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 13:14:01 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6bc71431995d49d4ca4a2ea9c75e5add5f345225 Cr-Commit-Position: refs/heads/master@{#33847}
4 years, 10 months ago (2016-02-09 13:14:23 UTC) #13
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1681923003/ by machenbach@chromium.org. ...
4 years, 10 months ago (2016-02-09 15:04:09 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678973002/1
4 years, 10 months ago (2016-02-11 11:56:41 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678973002/1
4 years, 10 months ago (2016-02-11 11:56:41 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 12:15:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678973002/1
4 years, 10 months ago (2016-02-11 12:27:43 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 12:30:14 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 12:31:43 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e35554214902d68a76ad5858e2b86787f72834a5
Cr-Commit-Position: refs/heads/master@{#33893}

Powered by Google App Engine
This is Rietveld 408576698