Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1681923002: Remove XMLHttpRequestProgressEvent (position and totalSize) (Closed)

Created:
4 years, 10 months ago by philipj_slow
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, timvolodine
CC:
android-webview-reviews_chromium.org, blink-reviews, chromium-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove XMLHttpRequestProgressEvent (position and totalSize) Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/bpbq0Rcpauk/cnpJtHddAgAJ BUG=357112 Committed: https://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b Cr-Commit-Position: refs/heads/master@{#374434}

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -218 lines) Patch
M android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/event-creation.html View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/event-creation-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/local/formdata/upload-events-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/chunked-progress-event-expectedLength.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/readystatechange.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/upload-onprogress-event-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/upload-progress-events.html View 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match.html View 1 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.h View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.idl View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681923002/20001
4 years, 10 months ago (2016-02-09 12:38:22 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 14:12:48 UTC) #4
philipj_slow
PTAL. There is some obvious follow-up to be done, like renaming XMLHttpRequestProgressEventThrottle, but I thought ...
4 years, 10 months ago (2016-02-09 17:39:25 UTC) #6
chrishtr
lgtm
4 years, 10 months ago (2016-02-09 18:14:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681923002/20001
4 years, 10 months ago (2016-02-09 18:15:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144269)
4 years, 10 months ago (2016-02-09 18:28:23 UTC) #11
philipj_slow
timvolodine@, can you review android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt?
4 years, 10 months ago (2016-02-09 19:00:31 UTC) #13
timvolodine
On 2016/02/09 19:00:31, philipj_UTC7 wrote: > timvolodine@, can you review > android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt? lgtm thanks!
4 years, 10 months ago (2016-02-09 19:08:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681923002/20001
4 years, 10 months ago (2016-02-09 19:18:32 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-09 20:11:50 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:12:53 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b
Cr-Commit-Position: refs/heads/master@{#374434}

Powered by Google App Engine
This is Rietveld 408576698