third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 1681923002: Remove XMLHttpRequestProgressEvent (position and totalSize)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1681923002: Remove XMLHttpRequestProgressEvent (position and totalSize) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.cpp ('k') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index e240113bd50041fca9098e1d1175de9b0a5a7191..d52c89cb03a857138134ec340e5f067479e41078 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -38,6 +38,7 @@

#include "core/dom/XMLDocument.h"

#include "core/editing/serializers/Serialization.h"

#include "core/events/Event.h"

+#include "core/events/ProgressEvent.h"

#include "core/fetch/CrossOriginAccessControl.h"

#include "core/fetch/FetchInitiatorTypeNames.h"

#include "core/fetch/FetchUtils.h"

@@ -59,7 +60,6 @@

#include "core/page/ChromeClient.h"

#include "core/page/Page.h"

#include "core/streams/Stream.h"

-#include "core/xmlhttprequest/XMLHttpRequestProgressEvent.h"

#include "core/xmlhttprequest/XMLHttpRequestUpload.h"

#include "platform/FileMetadata.h"

#include "platform/HTTPNames.h"

@@ -863,7 +863,7 @@ void XMLHttpRequest::createRequest(PassRefPtr<EncodedFormData> httpBody, Excepti

dispatchProgressEvent(EventTypeNames::loadstart, 0, 0);

if (httpBody && m_upload) {

uploadEvents = m_upload->hasEventListeners();

- m_upload->dispatchEvent(XMLHttpRequestProgressEvent::create(EventTypeNames::loadstart));

+ m_upload->dispatchEvent(ProgressEvent::create(EventTypeNames::loadstart, false, 0, 0));

}