Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1681903002: Add 'runnable' to Isolate service response (Closed)

Created:
4 years, 10 months ago by Bill Hesse
Modified:
4 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org, mit, Søren Gjesse
Base URL:
git@github.com:dart-lang/sdk.git@stable
Target Ref:
refs/heads/stable
Visibility:
Public.

Description

Add 'runnable' to Isolate service response BUG= R=rmacnak@google.com Review URL: https://codereview.chromium.org/1676233003 .

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M runtime/observatory/tests/service/get_version_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service/service.md View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Bill Hesse
This change did not merge cleanly into stable, because the protocol minor version had changed ...
4 years, 10 months ago (2016-02-09 10:11:49 UTC) #2
Cutch
4 years, 10 months ago (2016-02-09 15:43:12 UTC) #3
On 2016/02/09 10:11:49, Bill Hesse wrote:
> This change did not merge cleanly into stable, because the protocol minor
> version had changed to 3.1 with other unrelated(?) changes.
> 
> This proposed merge creates a new version number 3.3 used only for this stable
> version, that includes the protocol change in 3.2 but not that in 3.1.
> 
> Please verify that none of the other changes to the vm service need to be
> merged, and that bumping the version number this way is how you want to solve
> the problem.  I guess you would then bump bleeding-edge to 3.4 in the next
> change to the protocol.

Hi Bill,

Thanks for doing this but we can't bump the protocol version like this CL does.
I will discuss with people here about whether or not we just want to leave 1.4.x
in it's current state or merge all the changes so that the service protocol is
up to date with respect to the bleeding_edge.

John

Powered by Google App Engine
This is Rietveld 408576698