Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1676233003: Add 'runnable' to Isolate service response (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M runtime/observatory/tests/service/get_version_rpc_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service/service.md View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
4 years, 10 months ago (2016-02-08 18:06:29 UTC) #2
Cutch
4 years, 10 months ago (2016-02-08 18:06:33 UTC) #3
rmacnak
lgtm
4 years, 10 months ago (2016-02-08 18:13:10 UTC) #4
Cutch
4 years, 10 months ago (2016-02-08 18:14:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1e6c5f196befa21b26b3bd40877167691ee9c346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698