Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1681843002: restarts a song when the next track button is clicked and there is only one song in audio player (Closed)

Created:
4 years, 10 months ago by ryoh
Modified:
4 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

restarts a song when the next track button is clicked and there is only one song in audio player TEST=manually BUG=578691 Committed: https://crrev.com/e2962589814664bc7e976a0782a8d66c5589f720 Cr-Commit-Position: refs/heads/master@{#374327}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M ui/file_manager/audio_player/elements/audio_player.js View 1 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ryoh
Hi! Discussing with sgabriel@, and we decided that the song will be restarted when 'next-track' ...
4 years, 10 months ago (2016-02-09 03:48:31 UTC) #2
fukino
https://codereview.chromium.org/1681843002/diff/1/ui/file_manager/audio_player/elements/audio_player.js File ui/file_manager/audio_player/elements/audio_player.js (right): https://codereview.chromium.org/1681843002/diff/1/ui/file_manager/audio_player/elements/audio_player.js#newcode280 ui/file_manager/audio_player/elements/audio_player.js:280: if (this.$.trackList.currentTrackIndex == nextTrackIndex) { This condition is always ...
4 years, 10 months ago (2016-02-09 05:13:17 UTC) #3
ryoh
Thank you for the review. Please take another look! https://codereview.chromium.org/1681843002/diff/1/ui/file_manager/audio_player/elements/audio_player.js File ui/file_manager/audio_player/elements/audio_player.js (right): https://codereview.chromium.org/1681843002/diff/1/ui/file_manager/audio_player/elements/audio_player.js#newcode280 ui/file_manager/audio_player/elements/audio_player.js:280: ...
4 years, 10 months ago (2016-02-09 05:44:19 UTC) #4
fukino
lgtm
4 years, 10 months ago (2016-02-09 05:53:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681843002/20001
4 years, 10 months ago (2016-02-09 05:54:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-09 06:50:04 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 06:51:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2962589814664bc7e976a0782a8d66c5589f720
Cr-Commit-Position: refs/heads/master@{#374327}

Powered by Google App Engine
This is Rietveld 408576698