Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1681813004: Drop null/undefined check if we already check for IsUndetectable in BuildCompareNil (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Drop null/undefined check if we already check for IsUndetectable in BuildCompareNil Since https://codereview.chromium.org/1683643002/ null and undefined are also marked as undetectable. If we anyway need to check for that case, we can drop the null/undefined checks. BUG= Committed: https://crrev.com/0fc7b2c41ff1e7437b09b1e03d1c5ab7d72ec30f Cr-Commit-Position: refs/heads/master@{#33861}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -71 lines) Patch
M src/code-stubs.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 chunks +33 lines, -51 lines 0 comments Download
M src/ic/ic.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-02-09 13:26:54 UTC) #2
Benedikt Meurer
LGTM
4 years, 9 months ago (2016-02-09 13:49:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681813004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681813004/40001
4 years, 9 months ago (2016-02-10 10:06:46 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-02-10 10:39:55 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-10 10:40:34 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0fc7b2c41ff1e7437b09b1e03d1c5ab7d72ec30f
Cr-Commit-Position: refs/heads/master@{#33861}

Powered by Google App Engine
This is Rietveld 408576698