Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: src/ic/ic.h

Issue 1681813004: Drop null/undefined check if we already check for IsUndetectable in BuildCompareNil (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Minor cleanup Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_H_ 5 #ifndef V8_IC_H_
6 #define V8_IC_H_ 6 #define V8_IC_H_
7 7
8 #include "src/ic/ic-state.h" 8 #include "src/ic/ic-state.h"
9 #include "src/macro-assembler.h" 9 #include "src/macro-assembler.h"
10 #include "src/messages.h" 10 #include "src/messages.h"
(...skipping 630 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 641
642 class CompareNilIC : public IC { 642 class CompareNilIC : public IC {
643 public: 643 public:
644 explicit CompareNilIC(Isolate* isolate) : IC(EXTRA_CALL_FRAME, isolate) {} 644 explicit CompareNilIC(Isolate* isolate) : IC(EXTRA_CALL_FRAME, isolate) {}
645 645
646 Handle<Object> CompareNil(Handle<Object> object); 646 Handle<Object> CompareNil(Handle<Object> object);
647 647
648 static Handle<Code> GetUninitialized(); 648 static Handle<Code> GetUninitialized();
649 649
650 static void Clear(Address address, Code* target, Address constant_pool); 650 static void Clear(Address address, Code* target, Address constant_pool);
651
652 static Handle<Object> DoCompareNilSlow(Isolate* isolate, NilValue nil,
653 Handle<Object> object);
654 }; 651 };
655 652
656 653
657 class ToBooleanIC : public IC { 654 class ToBooleanIC : public IC {
658 public: 655 public:
659 explicit ToBooleanIC(Isolate* isolate) : IC(EXTRA_CALL_FRAME, isolate) {} 656 explicit ToBooleanIC(Isolate* isolate) : IC(EXTRA_CALL_FRAME, isolate) {}
660 657
661 Handle<Object> ToBoolean(Handle<Object> object); 658 Handle<Object> ToBoolean(Handle<Object> object);
662 }; 659 };
663 660
664 661
665 // Helper for BinaryOpIC and CompareIC. 662 // Helper for BinaryOpIC and CompareIC.
666 enum InlinedSmiCheck { ENABLE_INLINED_SMI_CHECK, DISABLE_INLINED_SMI_CHECK }; 663 enum InlinedSmiCheck { ENABLE_INLINED_SMI_CHECK, DISABLE_INLINED_SMI_CHECK };
667 void PatchInlinedSmiCode(Isolate* isolate, Address address, 664 void PatchInlinedSmiCode(Isolate* isolate, Address address,
668 InlinedSmiCheck check); 665 InlinedSmiCheck check);
669 666
670 } // namespace internal 667 } // namespace internal
671 } // namespace v8 668 } // namespace v8
672 669
673 #endif // V8_IC_H_ 670 #endif // V8_IC_H_
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698