third_party/WebKit/Source/core/svg/SVGURIReference.cpp - Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGURIReference.cpp

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/svg/SVGAnimatedString.h ('K') | « third_party/WebKit/Source/core/svg/SVGURIReference.h ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGURIReference.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGURIReference.cpp b/third_party/WebKit/Source/core/svg/SVGURIReference.cpp

index 941d9f418491669af8856ede28ccf66fbc08783c..6ca761a7da67124fcd1627e3e1059d4feae10882 100644

--- a/third_party/WebKit/Source/core/svg/SVGURIReference.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGURIReference.cpp

@@ -20,17 +20,16 @@

#include "core/svg/SVGURIReference.h"

-#include "core/XLinkNames.h"

#include "core/svg/SVGElement.h"

#include "platform/weborigin/KURL.h"

namespace blink {

SVGURIReference::SVGURIReference(SVGElement* element)

- : m_href(SVGAnimatedString::create(element, XLinkNames::hrefAttr, SVGString::create()))

+ : m_href(SVGAnimatedHref::create(element))

{

ASSERT(element);

- element->addToPropertyMap(m_href);

+ m_href->addToPropertyMap(element);

}

DEFINE_TRACE(SVGURIReference)

@@ -40,7 +39,7 @@ DEFINE_TRACE(SVGURIReference)

bool SVGURIReference::isKnownAttribute(const QualifiedName& attrName)

{

- return attrName.matches(XLinkNames::hrefAttr);

+ return SVGAnimatedHref::isKnownAttribute(attrName);

}

AtomicString SVGURIReference::fragmentIdentifierFromIRIString(const String& url, const TreeScope& treeScope)