Add support for 'href' (w/o XLink NS) for various SVG elements

third_party/WebKit/Source/core/svg/SVGAnimatedString.h

Index: third_party/WebKit/Source/core/svg/SVGAnimatedString.h
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedString.h b/third_party/WebKit/Source/core/svg/SVGAnimatedString.h
index e9da37c31ad8255101f6ec00d293fc6cb282e61f..4f4f484d5c95c63d3e6c8dd755fc4b9fca0b15f7 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimatedString.h
+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedString.h
@@ -36,7 +36,7 @@
 
 namespace blink {
 
-class SVGAnimatedString final : public SVGAnimatedProperty<SVGString> {
+class SVGAnimatedString : public SVGAnimatedProperty<SVGString> {
     DEFINE_WRAPPERTYPEINFO();
 public:
     static PassRefPtrWillBeRawPtr<SVGAnimatedString> create(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGString> initialValue)
@@ -44,9 +44,9 @@ public:
         return adoptRefWillBeNoop(new SVGAnimatedString(contextElement, attributeName, initialValue));
     }
 
-    String baseVal();
-    void setBaseVal(String, ExceptionState&);
-    String animVal();
+    virtual String baseVal();

[davve, 2016/02/10 17:47:39]

Do these three need to be virtual/still exist? As I understand it they were
added in https://codereview.chromium.org/1086873004 for counting. Now the
counting moves to SVGAnimatedHref, but these three are still around doing
nothing but delegate to the base class?

[fs, 2016/02/10 19:31:14]

Since we call these through a SVGAnimatedString* these need to be virtual for
the dispatch to reach the SVGAnimatedHref overrides when using
SVGURIReference.href. (These are not virtual in the base/ancestor class.)

[davve, 2016/02/11 07:37:08]

Of course, it's an SVGAnimatedString in SVGURIReference.idl. Got a bit fooled by
SVGURIReference::href() returning SVGAnimatedHref* instead of
SVGAnimatedString*, but that's perhaps customary. Bindings still only see
SVGAnimatedString, as I understand it.

[fs, 2016/02/11 09:48:18]

The reason for having SVGURIReference::href() return SVGAnimatedHref* is
actually to avoid having to make more accessors virtual (most prominently
currentValue.)

[davve, 2016/02/11 10:12:21]

Thanks for explaining.

+    virtual void setBaseVal(const String&, ExceptionState&);
+    virtual String animVal();
 
 protected:
     SVGAnimatedString(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGString> initialValue)