Add UseCounter for SVGURIReference.href.baseVal/animVal.

Add UseCounter for SVGURIReference.href.baseVal/animVal.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193870

[Erik Dahlström (inactive), 2015-04-15 14:17:49]

ed@opera.com changed reviewers:
+ fs@opera.com, pdr@chromium.org

[Erik Dahlström (inactive), 2015-04-15 14:17:50]

xlink:href was just deprecated in SVG2, count the uses of the corresponding SVG
DOM accessors href.animVal/baseVal, hopefully we can remove these in the future.

[fs, 2015-04-15 14:30:06]

https://codereview.chromium.org/1086873004/diff/20001/LayoutTests/fast/svg/hr...
File LayoutTests/fast/svg/href-baseval-animval.html (right):

https://codereview.chromium.org/1086873004/diff/20001/LayoutTests/fast/svg/hr...
LayoutTests/fast/svg/href-baseval-animval.html:28:
assert(window.internals.isUseCounted(document, 758), "has SVGHrefBaseVal
UseCounter: "); // 758 == UseCounter::Feature::SVGHrefBaseVal
This test looks more complicated than I had imagined that it heed to be [1].
Looks like it should have some form of expected result file too?

[1] What I imagined:
<svg-fragment>
<baseVal/animVal accesses>
assert_true(window.internals.isUseCounted(document, 758));

https://codereview.chromium.org/1086873004/diff/20001/Source/core/core.gypi
File Source/core/core.gypi (right):

https://codereview.chromium.org/1086873004/diff/20001/Source/core/core.gypi#n...
Source/core/core.gypi:3217: 'svg/SVGAnimatedString.cpp',
'S' before 'T'.

https://codereview.chromium.org/1086873004/diff/20001/Source/core/svg/SVGAnim...
File Source/core/svg/SVGAnimatedString.h (right):

https://codereview.chromium.org/1086873004/diff/20001/Source/core/svg/SVGAnim...
Source/core/svg/SVGAnimatedString.h:49: WTF::String animVal();
Why the need to namespace-qualify? (WTF:: and blink::)

[Erik Dahlström (inactive), 2015-04-16 08:39:36]

https://codereview.chromium.org/1086873004/diff/20001/LayoutTests/fast/svg/hr...
File LayoutTests/fast/svg/href-baseval-animval.html (right):

https://codereview.chromium.org/1086873004/diff/20001/LayoutTests/fast/svg/hr...
LayoutTests/fast/svg/href-baseval-animval.html:28:
assert(window.internals.isUseCounted(document, 758), "has SVGHrefBaseVal
UseCounter: "); // 758 == UseCounter::Feature::SVGHrefBaseVal
On 2015/04/15 14:30:06, fs wrote:
> This test looks more complicated than I had imagined that it heed to be [1].
> Looks like it should have some form of expected result file too?
> 
> [1] What I imagined:
> <svg-fragment>
> <baseVal/animVal accesses>
> assert_true(window.internals.isUseCounted(document, 758));

Done.

https://codereview.chromium.org/1086873004/diff/20001/Source/core/core.gypi
File Source/core/core.gypi (right):

https://codereview.chromium.org/1086873004/diff/20001/Source/core/core.gypi#n...
Source/core/core.gypi:3217: 'svg/SVGAnimatedString.cpp',
On 2015/04/15 14:30:06, fs wrote:
> 'S' before 'T'.

Done.

https://codereview.chromium.org/1086873004/diff/20001/Source/core/svg/SVGAnim...
File Source/core/svg/SVGAnimatedString.h (right):

https://codereview.chromium.org/1086873004/diff/20001/Source/core/svg/SVGAnim...
Source/core/svg/SVGAnimatedString.h:49: WTF::String animVal();
On 2015/04/15 14:30:06, fs wrote:
> Why the need to namespace-qualify? (WTF:: and blink::)

Copy-paste cruft, dropped.

[fs, 2015-04-16 08:55:07]

lgtm

https://codereview.chromium.org/1086873004/diff/40001/LayoutTests/fast/svg/hr...
File LayoutTests/fast/svg/href-baseval-animval.html (right):

https://codereview.chromium.org/1086873004/diff/40001/LayoutTests/fast/svg/hr...
LayoutTests/fast/svg/href-baseval-animval.html:9: var baseval =
target.href.baseVal;
Nit: Could've been scoped within the corresponding test, but no big deal.

[Erik Dahlström (inactive), 2015-04-16 10:18:57]

The CQ bit was checked by ed@opera.com

[Erik Dahlström (inactive), 2015-04-16 10:18:58]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1086873004/#ps60001
(title: "fix nit + rebase")

[commit-bot: I haz the power, 2015-04-16 10:19:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1086873004/60001

[commit-bot: I haz the power, 2015-04-16 14:55:57]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193870