third_party/WebKit/Source/core/dom/Element.cpp - Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove invalid assert. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/dom/href-semantics.html ('K') | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/dom/VisitedLinkState.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGAnimatedHref.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 7fbdd94c4772e4e492671f35a04a0fe61af96e7d..73f5f2b03ec669330fa81e504d47c582304d8d2c 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -2915,8 +2915,11 @@ KURL Element::hrefURL() const

// <link> implement URLUtils?

if (isHTMLAnchorElement(*this) || isHTMLAreaElement(*this) || isHTMLLinkElement(*this))

return getURLAttribute(hrefAttr);

- if (isSVGAElement(*this))

+ if (isSVGAElement(*this)) {

+ if (hasAttribute(SVGNames::hrefAttr))

+ return getURLAttribute(SVGNames::hrefAttr);

return getURLAttribute(XLinkNames::hrefAttr);

+ }

return KURL();

}