Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove invalid assert. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2897 matching lines...) Expand 10 before | Expand all | Expand 10 after
2908 rareData.setDataset(DatasetDOMStringMap::create(this)); 2908 rareData.setDataset(DatasetDOMStringMap::create(this));
2909 return *rareData.dataset(); 2909 return *rareData.dataset();
2910 } 2910 }
2911 2911
2912 KURL Element::hrefURL() const 2912 KURL Element::hrefURL() const
2913 { 2913 {
2914 // FIXME: These all have href() or url(), but no common super class. Why doe sn't 2914 // FIXME: These all have href() or url(), but no common super class. Why doe sn't
2915 // <link> implement URLUtils? 2915 // <link> implement URLUtils?
2916 if (isHTMLAnchorElement(*this) || isHTMLAreaElement(*this) || isHTMLLinkElem ent(*this)) 2916 if (isHTMLAnchorElement(*this) || isHTMLAreaElement(*this) || isHTMLLinkElem ent(*this))
2917 return getURLAttribute(hrefAttr); 2917 return getURLAttribute(hrefAttr);
2918 if (isSVGAElement(*this)) 2918 if (isSVGAElement(*this)) {
2919 if (hasAttribute(SVGNames::hrefAttr))
2920 return getURLAttribute(SVGNames::hrefAttr);
2919 return getURLAttribute(XLinkNames::hrefAttr); 2921 return getURLAttribute(XLinkNames::hrefAttr);
2922 }
2920 return KURL(); 2923 return KURL();
2921 } 2924 }
2922 2925
2923 KURL Element::getURLAttribute(const QualifiedName& name) const 2926 KURL Element::getURLAttribute(const QualifiedName& name) const
2924 { 2927 {
2925 #if ENABLE(ASSERT) 2928 #if ENABLE(ASSERT)
2926 if (elementData()) { 2929 if (elementData()) {
2927 if (const Attribute* attribute = attributes().find(name)) 2930 if (const Attribute* attribute = attributes().find(name))
2928 ASSERT(isURLAttribute(*attribute)); 2931 ASSERT(isURLAttribute(*attribute));
2929 } 2932 }
(...skipping 688 matching lines...) Expand 10 before | Expand all | Expand 10 after
3618 { 3621 {
3619 #if ENABLE(OILPAN) 3622 #if ENABLE(OILPAN)
3620 if (hasRareData()) 3623 if (hasRareData())
3621 visitor->trace(elementRareData()); 3624 visitor->trace(elementRareData());
3622 visitor->trace(m_elementData); 3625 visitor->trace(m_elementData);
3623 #endif 3626 #endif
3624 ContainerNode::trace(visitor); 3627 ContainerNode::trace(visitor);
3625 } 3628 }
3626 3629
3627 } // namespace blink 3630 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698