Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase; update comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp b/third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp
index b3c2053e4cd1955411193b64c62adb95e802e7ae..84787c20a20a70a875809eb6267aea0326082c5e 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp
@@ -4,30 +4,20 @@
#include "core/svg/SVGAnimatedString.h"
-#include "core/XLinkNames.h"
-#include "core/frame/UseCounter.h"
-#include "core/svg/SVGElement.h"
-
namespace blink {
String SVGAnimatedString::baseVal()
{
- if (this->attributeName() == XLinkNames::hrefAttr)
- UseCounter::count(this->contextElement()->document(), UseCounter::SVGHrefBaseVal);
return SVGAnimatedProperty<SVGString>::baseVal();
}
-void SVGAnimatedString::setBaseVal(String value, ExceptionState& exceptionState)
+void SVGAnimatedString::setBaseVal(const String& value, ExceptionState& exceptionState)
{
- if (this->attributeName() == XLinkNames::hrefAttr)
- UseCounter::count(this->contextElement()->document(), UseCounter::SVGHrefBaseVal);
return SVGAnimatedProperty<SVGString>::setBaseVal(value, exceptionState);
}
String SVGAnimatedString::animVal()
{
- if (this->attributeName() == XLinkNames::hrefAttr)
- UseCounter::count(this->contextElement()->document(), UseCounter::SVGHrefAnimVal);
return SVGAnimatedProperty<SVGString>::animVal();
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimatedString.h ('k') | third_party/WebKit/Source/core/svg/SVGAttributeNames.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698