Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimatedString.h

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase; update comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAnimatedString.h
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedString.h b/third_party/WebKit/Source/core/svg/SVGAnimatedString.h
index e9da37c31ad8255101f6ec00d293fc6cb282e61f..4f4f484d5c95c63d3e6c8dd755fc4b9fca0b15f7 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimatedString.h
+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedString.h
@@ -36,7 +36,7 @@
namespace blink {
-class SVGAnimatedString final : public SVGAnimatedProperty<SVGString> {
+class SVGAnimatedString : public SVGAnimatedProperty<SVGString> {
DEFINE_WRAPPERTYPEINFO();
public:
static PassRefPtrWillBeRawPtr<SVGAnimatedString> create(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGString> initialValue)
@@ -44,9 +44,9 @@ public:
return adoptRefWillBeNoop(new SVGAnimatedString(contextElement, attributeName, initialValue));
}
- String baseVal();
- void setBaseVal(String, ExceptionState&);
- String animVal();
+ virtual String baseVal();
+ virtual void setBaseVal(const String&, ExceptionState&);
+ virtual String animVal();
protected:
SVGAnimatedString(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGString> initialValue)
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimatedHref.cpp ('k') | third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698