Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1681533002: simplify piex.gyp (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

simplify piex.gyp Was just starting to dig into skia:4903, and decided to start by learning piex. It's tiny. Why such GYP complexity to build 5 files? BUG=skia:4903 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681533002 Committed: https://skia.googlesource.com/skia/+/b9c61f7a6e32cf5b17c16da484b3fe5902ba92f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -66 lines) Patch
M gyp/piex.gyp View 1 chunk +9 lines, -66 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mtklein_C
4 years, 10 months ago (2016-02-08 14:06:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681533002/1
4 years, 10 months ago (2016-02-08 14:06:14 UTC) #5
msarett
lgtm
4 years, 10 months ago (2016-02-08 14:21:38 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 14:31:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681533002/1
4 years, 10 months ago (2016-02-08 14:32:22 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 14:33:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b9c61f7a6e32cf5b17c16da484b3fe5902ba92f0

Powered by Google App Engine
This is Rietveld 408576698