Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: gyp/piex.gyp

Issue 1681533002: simplify piex.gyp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/piex.gyp
diff --git a/gyp/piex.gyp b/gyp/piex.gyp
index 7822cd5cdf967c95479d470b3c99785e04bcb842..b2a1f36ce859ca3a8dcdc911c7f13ae0a38c9c77 100644
--- a/gyp/piex.gyp
+++ b/gyp/piex.gyp
@@ -28,76 +28,19 @@
'target_name': 'piex',
'type': 'static_library',
'sources': [
+ '../third_party/externals/piex/src/binary_parse/cached_paged_byte_array.cc',
+ '../third_party/externals/piex/src/binary_parse/range_checked_byte_ptr.cc',
+ '../third_party/externals/piex/src/image_type_recognition/image_type_recognition_lite.cc',
'../third_party/externals/piex/src/piex.cc',
+ '../third_party/externals/piex/src/tiff_directory/tiff_directory.cc',
'../third_party/externals/piex/src/tiff_parser.cc',
],
- 'variables': {
- 'headers': [
- '../third_party/externals/piex/src/piex.h',
- '../third_party/externals/piex/src/piex_types.h',
- '../third_party/externals/piex/src/tiff_parser.h',
- ],
- },
- 'include_dirs': ['../third_party/externals/piex'],
- 'cflags': [
- '-Wsign-compare',
- '-w',
- ],
- 'msvs_settings': {
- 'VCCLCompilerTool': {
- 'WarningLevel': '0',
- },
- },
- 'xcode_settings': {
- 'WARNING_CFLAGS': ['-w'],
- },
- 'dependencies': [
- 'binary_parse',
- 'image_type_recognition',
- 'tiff_directory',
- ],
+ 'include_dirs': [ '../third_party/externals/piex' ],
'direct_dependent_settings': {
- 'include_dirs': [
- '../third_party/externals/piex',
- ],
- },
-}, {
- 'target_name': 'binary_parse',
- 'type': 'static_library',
- 'sources': [
- '../third_party/externals/piex/src/binary_parse/cached_paged_byte_array.cc',
- '../third_party/externals/piex/src/binary_parse/range_checked_byte_ptr.cc',
- ],
- 'variables': {
- 'headers': [
- '../third_party/externals/piex/src/binary_parse/cached_paged_byte_array.h',
- '../third_party/externals/piex/src/binary_parse/range_checked_byte_ptr.h',
- ],
- },
- 'include_dirs': ['../third_party/externals/piex'],
- 'cflags': ['-Wsign-compare'],
-}, {
- 'target_name': 'image_type_recognition',
- 'type': 'static_library',
- 'sources': [
- '../third_party/externals/piex/src/image_type_recognition/image_type_recognition_lite.cc',
- ],
- 'variables': {
- 'headers': ['../third_party/externals/piex/src/image_type_recognition/image_type_recognition_lite.h'],
- },
- 'include_dirs': ['../third_party/externals/piex'],
- 'cflags': ['-Wsign-compare'],
- 'dependencies': ['binary_parse'],
-}, {
- 'target_name': 'tiff_directory',
- 'type': 'static_library',
- 'sources': [
- '../third_party/externals/piex/src/tiff_directory/tiff_directory.cc',
- ],
- 'variables': {
- 'headers': ['../third_party/externals/piex/src/tiff_directory/tiff_directory.h'],
+ 'include_dirs': [ '../third_party/externals/piex' ],
},
- 'include_dirs': ['../third_party/externals/piex'],
- 'dependencies': ['binary_parse'],
+ 'cflags': [ '-w' ],
+ 'msvs_settings': { 'VCCLCompilerTool': { 'WarningLevel': '0' } },
+ 'xcode_settings': { 'WARNING_CFLAGS': ['-w'] },
}],
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698