Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1681463003: Preference for Presentation Mode/Fullscreen Toolbar (Closed)

Created:
4 years, 10 months ago by spqchan
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Preference for Presentation Mode/Fullscreen Toolbar Fixes the issue with the test on 10.10 for the commit: https://chromium.googlesource.com/chromium/src/+/048c293643242dc0357c8bc8651d1c251559a400 BUG=544307 Review URL: https://codereview.chromium.org/1650713003 TBR=miu@chromium.org Cr-Commit-Position: refs/heads/master@{#373695} (cherry picked from commit cae22576c51838b5c32a2d489e8c6187dc3c451f) Committed: https://chromium.googlesource.com/chromium/src/+/27b2a905193cf876e0a70b81c77e05f40719f296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -34 lines) Patch
M chrome/app/nibs/MainMenu.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_ui_prefs.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_command_handler.mm View 4 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 4 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 5 chunks +48 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/exclusive_access/exclusive_access_context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
spqchan
4 years, 10 months ago (2016-02-09 02:14:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
27b2a905193cf876e0a70b81c77e05f40719f296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698