Preference for Presentation Mode/Fullscreen Toolbar

Preference for Presentation Mode/Fullscreen Toolbar

Fixes the issue with the test on 10.10 for the commit: https://chromium.googlesource.com/chromium/src/+/048c293643242dc0357c8bc8651d1c251559a400

BUG=544307
Committed: https://crrev.com/cae22576c51838b5c32a2d489e8c6187dc3c451f
Cr-Commit-Position: refs/heads/master@{#373695}

[spqchan, 2016-01-30 01:37:51]

Description was changed from

==========
Preference for Presentation Mode/Fullscreen Toolbar

Fixes the test for OSX 10.10 in
https://chromium.googlesource.com/chromium/src/+/048c293643242dc0357c8bc8651d...


BUG=544307
==========

to

==========
Preference for Presentation Mode/Fullscreen Toolbar

Fixes the issue with the test on 10.10 for the commit:
https://chromium.googlesource.com/chromium/src/+/048c293643242dc0357c8bc8651d...


BUG=544307
==========

[spqchan, 2016-01-30 01:38:11]

spqchan@chromium.org changed reviewers:
+ miu@chromium.org, thakis@chromium.org

[spqchan, 2016-01-30 01:42:11]

On 2016/01/30 01:38:11, spqchan wrote:
> mailto:spqchan@chromium.org changed reviewers:
> + mailto:miu@chromium.org, mailto:thakis@chromium.org

Can you review this again? The changes I made compared to what was LGTMed in the
last CL is shown on the 2nd patch here.
I made sure to run browser_tests locally on every version of OSX so hopefully
this will be the last.
Thanks!

[miu, 2016-02-02 03:58:16]

Diff between PS1 and PS2 lgtm.  However, I defer to Nico to make sure this is
the right approach.

[spqchan, 2016-02-03 19:33:04]

On 2016/02/02 03:58:16, miu wrote:
> Diff between PS1 and PS2 lgtm.  However, I defer to Nico to make sure this is
> the right approach.

The rebase is rather large, since a good chunk of BrowserWindowController was
recently refactored.
The only change I made for the rebase is moving my changes in
browser_window_cocoa.mm to exclusive_access_controller_views.mm

[spqchan, 2016-02-04 01:30:25]

On 2016/02/03 19:33:04, spqchan wrote:
> On 2016/02/02 03:58:16, miu wrote:
> > Diff between PS1 and PS2 lgtm.  However, I defer to Nico to make sure this
is
> > the right approach.
> 
> The rebase is rather large, since a good chunk of BrowserWindowController was
> recently refactored.
> The only change I made for the rebase is moving my changes in
> browser_window_cocoa.mm to exclusive_access_controller_views.mm

I also removed a couple of conflicts in Patch 4

[Nico, 2016-02-04 22:08:12]

still lgtm. when you reland patches that have been reviewed already and someone
ok'd the diff, you don't need to get a review on the full patch.

[spqchan, 2016-02-04 22:11:38]

On 2016/02/04 22:08:12, Nico wrote:
> still lgtm. when you reland patches that have been reviewed already and
someone
> ok'd the diff, you don't need to get a review on the full patch.

Great, thanks for the heads up!

[spqchan, 2016-02-04 22:11:44]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-02-04 22:11:45]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1650713003/#ps60001
(title: "Removed some rebase conflicts")

[commit-bot: I haz the power, 2016-02-04 22:14:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650713003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650713003/60001

[commit-bot: I haz the power, 2016-02-04 22:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 22:20:35]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[spqchan, 2016-02-04 23:54:30]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-02-04 23:54:30]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1650713003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-02-04 23:56:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650713003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650713003/80001

[commit-bot: I haz the power, 2016-02-05 00:59:25]

Description was changed from

==========
Preference for Presentation Mode/Fullscreen Toolbar

Fixes the issue with the test on 10.10 for the commit:
https://chromium.googlesource.com/chromium/src/+/048c293643242dc0357c8bc8651d...


BUG=544307
==========

to

==========
Preference for Presentation Mode/Fullscreen Toolbar

Fixes the issue with the test on 10.10 for the commit:
https://chromium.googlesource.com/chromium/src/+/048c293643242dc0357c8bc8651d...


BUG=544307
==========

[commit-bot: I haz the power, 2016-02-05 00:59:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-05 01:00:47]

Description was changed from

==========
Preference for Presentation Mode/Fullscreen Toolbar

Fixes the issue with the test on 10.10 for the commit:
https://chromium.googlesource.com/chromium/src/+/048c293643242dc0357c8bc8651d...


BUG=544307
==========

to

==========
Preference for Presentation Mode/Fullscreen Toolbar

Fixes the issue with the test on 10.10 for the commit:
https://chromium.googlesource.com/chromium/src/+/048c293643242dc0357c8bc8651d...

BUG=544307

Committed: https://crrev.com/cae22576c51838b5c32a2d489e8c6187dc3c451f
Cr-Commit-Position: refs/heads/master@{#373695}
==========

[commit-bot: I haz the power, 2016-02-05 01:00:48]

Patchset 5 (id:??) landed as
https://crrev.com/cae22576c51838b5c32a2d489e8c6187dc3c451f
Cr-Commit-Position: refs/heads/master@{#373695}